Update BetaYields #192
Merged
Update BetaYields #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ea0df7c.
|
@HenningSE I added a dummy function in the tests so the automatic tests finally pass. I also removed dependency from g1 and g2. The file with the function for the yields is still to be passed manually with a file path, because I think it still needs some work before uploading it. I believe the PR can go like this for the moment, to make it easier to work and test the functionality? |
Mem eff input
Lineage clustering
Beta yields
|
Hi @cfuselli, the dummy function is a good idea for the tests, thanks! I think the PR is good to go and we can merge together with all the other high energy-focused PRs very soon. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Lineage clustering
for more information, see https://pre-commit.ci
cfuselli
approved these changes
Jun 27, 2024
|
I tested it and it seems like it runs smoothly:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a copy of the work done in #168. A new PR was opened to allow the automatic tests to run.